Alexander Wels has posted comments on this change.
Change subject: webadmin: (WiP) Improve UI Plugin vs. REST API integration
......................................................................
Patch Set 1:
(1 comment)
Is it me, or don't I see the code that stops the REST api heartbeat by setting
the session id to null? Since this is still a WIP I am assuming it hasn't been
implemented yet.
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java
Line 53: if (uiModeData != null) {
Line 54: handleUiMode(uiModeData);
Line 55: }
Line 56:
Line 57: EngineSessionTimeoutData engineSessionTimeoutData =
EngineSessionTimeoutData.instance();
I am assuming we can't just inject a singleton instead of using a static
instance?
Line 58: if (engineSessionTimeoutData != null) {
Line 59:
restApiSessionManager.setSessionTimeout(engineSessionTimeoutData.getValue());
Line 60: }
Line 61: }
--
To view, visit http://gerrit.ovirt.org/20404
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b913e78c0ddb54011670c421d6ff5d12c965d6b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
