Mike Kolesnik has posted comments on this change.
Change subject: engine: Prevent vnic live update for if network not on host
......................................................................
Patch Set 3:
(1 comment)
Basically +2, one small comment
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java
Line 219: if
(!validate(nicValidator.hotUpdateDoneWithInternalNetwork(oldNetwork, network)))
{
Line 220: return false;
Line 221: }
Line 222:
Line 223: if (!validate(nicValidator.networkExistsOnHost(network)))
{
You can use || instead of splitting to 2 ifs
Line 224: return false;
Line 225: }
Line 226: }
Line 227:
--
To view, visit http://gerrit.ovirt.org/20188
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c9d8f2202efa2e45a2144bbdb70d374bdb9ff6f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches