Alon Bar-Lev has posted comments on this change.

Change subject: packaging: setup: drop tables on restore
......................................................................


Patch Set 3:

> > Please revert, this will cause restored database to be dirty as if object X 
> > exists it won't be dropped unless exists in the backup file.

> So reverting won't help - as the commit message says, without this you'll 
> simply get duplicate lines.

first revert, then we need to exit at first error.

then at different patch may or may not empty content of database before restore.

-- 
To view, visit http://gerrit.ovirt.org/20352
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bdd8c01349b3cb2a4b1ab79a048c09479c23f27
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to