Sandro Bonazzola has posted comments on this change. Change subject: agent: enable local maintenance mode ......................................................................
Patch Set 1: -Code-Review (2 comments) .................................................... File ovirt_hosted_engine_ha/client/client.py Line 216: Line 217: def set_maintenance_mode(self, mode, value): Line 218: if mode == self.MaintenanceMode.GLOBAL: Line 219: self.set_global_md_flag(self.GlobalMdFlags.MAINTENANCE, Line 220: str(value)) why not util.to_bool here? Line 221: Line 222: elif mode == self.MaintenanceMode.LOCAL: Line 223: if self._config is None: Line 224: self._config = config.Config() Line 225: self._config.set(config.HA, Line 226: config.LOCAL_MAINTENANCE, Line 227: str(util.to_bool(value))) Line 228: Line 229: else: How to unset the mainteinance flag? -- To view, visit http://gerrit.ovirt.org/20278 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60e62cd03daec812e16a3a5bbd2d3d896e41402d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
