Michael Pasternak has posted comments on this change.
Change subject: restapi: Adding details to step as statistics
......................................................................
Patch Set 12: Code-Review-1
(2 comments)
all in all the patch is okay!, please add /statistics
descriptor to rsdl_metadata.yaml
thanks.
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 369:
Line 370: <xs:complexType name="Value">
Line 371: <xs:sequence>
Line 372: <xs:element name="datum" type="xs:decimal" minOccurs="1"
maxOccurs="1"/>
Line 373: <xs:element name="str_datum" type="xs:string" minOccurs="1"
maxOccurs="1"/>
not sure i like the name, 'detail' maybe ??
Line 374: <!-- will in the future also include a timestamp element,
Line 375: when historical data is supported -->
Line 376: </xs:sequence>
Line 377: </xs:complexType>
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStepResource.java
Line 66: return step;
Line 67: }
Line 68:
Line 69: @Override
Line 70: @Path("statistics")
@Path annotations should be in interfaces only
Line 71: public StatisticsResource getStatisticsResource() {
Line 72:
Line 73: GlusterTaskStatisticalQuery query = new
GlusterTaskStatisticalQuery(new TaskQueryResolver<Guid>(), newModel(id));
Line 74: return inject(new BackendStatisticsResource<Step,
GlusterVolumeTaskStatusEntity>(GlusterVolumeTaskStatusEntity.class, guid,
query));
--
To view, visit http://gerrit.ovirt.org/19685
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1f7559d5700823cd4ee0a28a826074d22679d23
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
