Alissa Bonas has posted comments on this change.

Change subject: engine: add space after comma checkstyle
......................................................................


Patch Set 4:

(1 comment)

....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/template/StoragesTree.java
Line 27: import com.google.gwt.user.client.ui.HorizontalPanel;
Line 28: import com.google.gwt.user.client.ui.Image;
Line 29: import com.google.gwt.user.client.ui.TreeItem;
Line 30: 
Line 31: public class StoragesTree extends 
AbstractSubTabTree<TemplateStorageListModel, StorageDomainModel, DiskModel> {
I think it's because the file was previously edited in dos.
Looks like dos2unix should be run on this file and recommit it  - like in this 
patch:
http://gerrit.ovirt.org/#/c/16020/
After this current patch of checkstyle is merged, I will try to re-edit this 
particular file with dos2unix and commit, ok?
Line 32: 
Line 33:     ApplicationResources resources;
Line 34:     ApplicationConstants constants;
Line 35: 


-- 
To view, visit http://gerrit.ovirt.org/20406
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f79d9656a65c18f6c8944c96448f0d4a4d349c0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to