Lior Vernia has posted comments on this change.
Change subject: webadmin: Remove vNIC items changed listener before flush
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
Line 1335: }
Line 1336:
Line 1337: @Override
Line 1338: public UnitVmModel flush() {
Line 1339: UnitVmModel model = driver.flush();
I wouldn't wanna clean *all* listeners (as some of them might be waiting
exactly for that flush...), however I can move both this specific handler's
registration and removal into ProfilesInstanceTypeEditor.
Line 1340:
Line 1341:
model.getNicsWithLogicalNetworks().getItemsChangedEvent().removeListener(vnicsChangedListener);
Line 1342: profilesInstanceTypeEditor.flush();
Line 1343:
--
To view, visit http://gerrit.ovirt.org/20398
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f153a3b19e467d41131015c7e2819c3ce365c22
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
