Mike Kolesnik has posted comments on this change. Change subject: core : Change inheritance tree of DiskImage ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) Need to handle compensation correctly, this way it will not work since it relies on getId field (not getImageId) .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java Line 162: List<Guid> imagesList = new ArrayList<Guid>(); This unused, I think u can delete it (maybe separate patch?) -- To view, visit http://gerrit.ovirt.org/3719 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bfc9c6aca8bedd21f022c9749511ec503054587 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
