Lior Vernia has posted comments on this change. Change subject: engine: Copying a quota drops consumers and permissions ......................................................................
Patch Set 1: Code-Review+1 (1 comment) Frontend changes look good to me. Not specific to this patch, you might want to create an inheritance hierarchy within QuotaModel, so that: * QuotaModel is abstract. * From it will inherit NewQuotaModel and EditQuotaModel. * From EditQuotaModel will inherit CloneQuotaModel. And move into their constructors all the field initialization that's specific to each of them, might be more easily-maintainable in the long run than managing everything with "if" clauses in QuotaListModel. .................................................... File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/QuotaPopupView.ui.xml Line 59: <g:HorizontalPanel> Line 60: <e:EntityModelTextBoxEditor ui:field="nameEditor" /> Line 61: <e:EntityModelTextBoxEditor ui:field="descriptionEditor" /> Line 62: </g:HorizontalPanel> Line 63: <g:HorizontalPanel> Not related to the patch, but I don't think this panel is actually required, consider removing it as part of another patch. Line 64: <e:ListModelListBoxEditor ui:field="dataCenterEditor" /> Line 65: </g:HorizontalPanel> Line 66: <e:EntityModelCheckBoxEditor ui:field="copyPermissionsEditor" /> Line 67: </g:FlowPanel> -- To view, visit http://gerrit.ovirt.org/20449 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide6f9ded5c19d16f7b4c7e373df9664e59fb1419 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
