Roy Golan has posted comments on this change.
Change subject: host-deploy: output stderr content as error in audit log
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHDialog.java
Line 320: throw e;
Line 321: }
Line 322:
Line 323: log.error(
Line 324: "Swallowing exception as preferring stderr",
interesting - is this a real usecase - where the ssh command failed (stderr >0)
and some runtime failure in the code afterwards?
Line 325: e
Line 326: );
Line 327: }
Line 328: finally {
Line 328: finally {
Line 329: if (stderr.size() > 0) {
Line 330: throw new RuntimeException(
Line 331: String.format(
Line 332: "Unexpected error during execution: %1$s",
why did you leave the command out of the log?
Line 333: new String(stderr.toByteArray(),
Charset.forName("UTF-8"))
Line 334: )
Line 335: );
Line 336: }
--
To view, visit http://gerrit.ovirt.org/20395
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If1cc9bf7e9e9875965fa4830c68e2a63d801b96b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
