Liron Ar has uploaded a new change for review. Change subject: core: ReconstructMasterParameters - return removed initialization ......................................................................
core: ReconstructMasterParameters - return removed initialization In change I3bb06f63b6fae8d4bc0c2b931cbfeb6b71a023a9, the initialization of the member privateNewMasterDomainId has been moved to the ctor. The issue is that the initialization was placed only in some of the ctors leading the unexpected behaviour when reconstruct is executed. Change-Id: I752c8065ee15faaeb6ffd41909d349297b8a3a58 Signed-off-by: Liron Aravot <[email protected]> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ReconstructMasterParameters.java 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/64/20564/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ReconstructMasterParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ReconstructMasterParameters.java index f66bb4e..9ae2886 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ReconstructMasterParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ReconstructMasterParameters.java @@ -14,12 +14,12 @@ public ReconstructMasterParameters(Guid storagePoolId, Guid storageDomainId, boolean isInactive) { super(storageDomainId, storagePoolId); + privateNewMasterDomainId = Guid.Empty; setInactive(isInactive); } public ReconstructMasterParameters(Guid storagePoolId, Guid storageDomainId, boolean isInactive, boolean canChooseInactiveDomainAsMaster) { - super(storageDomainId, storagePoolId); - setInactive(isInactive); + this(storageDomainId, storagePoolId, isInactive); setCanChooseInactiveDomainAsMaster(canChooseInactiveDomainAsMaster); } -- To view, visit http://gerrit.ovirt.org/20564 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I752c8065ee15faaeb6ffd41909d349297b8a3a58 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
