Gilad Chaplik has uploaded a new change for review. Change subject: webadmin: loading indicator is shown wrongfully ......................................................................
webadmin: loading indicator is shown wrongfully There seems to be a race between setting loading indicator to setting the data in subtabs' tables. subtab.OnReveal is invoked after the data is loaded. Initially the loading indicator is set, so reseting it after the subtab is hidden. Change-Id: I1c520cab936750fbbb74950c70ef9e74ad326c2b Signed-off-by: Gilad Chaplik <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractSubTabPresenter.java 1 file changed, 9 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/95/20595/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractSubTabPresenter.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractSubTabPresenter.java index 67dbc92..c559ccd 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractSubTabPresenter.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractSubTabPresenter.java @@ -77,6 +77,15 @@ } @Override + protected void onHide() { + super.onHide(); + // set loading state for next reveal + if (getTable() != null) { + getTable().setLoadingState(LoadingState.LOADING); + } + } + + @Override protected void onBind() { super.onBind(); @@ -117,10 +126,6 @@ // Notify model provider that the tab has been revealed modelProvider.onSubTabSelected(); - - if (getTable() != null) { - getTable().setLoadingState(LoadingState.LOADING); - } } @Override -- To view, visit http://gerrit.ovirt.org/20595 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1c520cab936750fbbb74950c70ef9e74ad326c2b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
