Kanagaraj M has posted comments on this change.
Change subject: webadmin : Aligning the rows in the Hosts General sub-tab
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java
Line 172: formBuilder.addFormItem(new
FormItem(constants.swapSizeHostGeneral(), swapSizeDetails, 1, 2));
Line 173: formBuilder.addFormItem(new
FormItem(constants.sharedMemHostGeneral(), sharedMemory, 2, 2));
Line 174: formBuilder.addFormItem(new
FormItem(constants.memPageSharingHostGeneral(), memoryPageSharing, 3, 2));
Line 175: formBuilder.addFormItem(new
FormItem(constants.autoLargePagesHostGeneral(), automaticLargePage, 4, 2));
Line 176:
Here the code is getting duplicated.
Lets say there is a new field in future which is applicable to both virt and
gluster, in that case the field should be added to both the section.
Line 177: }
Line 178: }
Line 179:
Line 180: void initMemorySizeLabels() {
--
To view, visit http://gerrit.ovirt.org/20603
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8023616e95d2b52a0c4f813037df1e7f10e6083f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
