Ori Liel has posted comments on this change.
Change subject: restapi: REST API to stop migrate on brick
......................................................................
Patch Set 9: Code-Review+1
(3 comments)
Looks good, I had small comments\questions, please address them and I'll be
able to give +2
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
Line 3906: description: stops the bricks migration task started on on
volume
Line 3907: urlparams: {}
Line 3908: headers:
Line 3909: Content-Type: {value: application/xml|json, required: true}
Line 3910: Correlation-Id: {value: 'any string', required: false}
Looks good, I have a general question: what happens if user did migrate of
bricks A,B,C and then stop-migration only on bricks A,B? Is that a legal
scenario?
Line 3911: - name:
/api/clusters/{cluster:id}/glustervolumes/{glustervolume:id}/bricks/{brick:id}/replace|rel=replace
Line 3912: description: replace the specified brick with a new brick
directory in the gluster volume attached to the cluster
Line 3913: request:
Line 3914: body:
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBricksResource.java
Line 262: GlusterVolumeRemoveBricksParameters params =
toParameters(action);
Line 263: return
performAction(VdcActionType.StopRemoveGlusterVolumeBricks, params, action,
false);
Line 264: }
Line 265:
Line 266: @Override
Michael had some comments on existing code in toParameters() (see parameter set
7). If you're not going to implement them in this patch, please make sure to
send a separate patch for them (and if you did and I simply didn't notice it
yet, I apologize in advance).
Line 267: public ActionResource getActionSubresource(String action, String
id) {
Line 268: return inject(new BackendActionResource(action, id));
Line 269: }
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java
Line 380:
Line 381: private void addGlusterBricksFeature(Features features) {
Line 382: Feature feature = new Feature();
Line 383: feature.setName("Gluster Bricks management");
Line 384: feature.setDescription("Ability to delete gluster bricks with
data migration");
I think Michael meant adding something like: "...using 'migrate' and
'stopmigration' actions..." (Michael said: "I'd mention the actual action used
for that")
Line 385: features.getFeature().add(feature);
Line 386: }
--
To view, visit http://gerrit.ovirt.org/19411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bba03cf04bed8041cb4e25cac0748afbeed2261
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
