Omer Frenkel has posted comments on this change.
Change subject: backend: add a new specific VDS_CONNECTION_ERROR
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStopVDSCommand.java
Line 54: VDSError error = new VDSError();
Line 55: error.setCode(VdcBllErrors.TaskInProgress);
Line 56: getVDSReturnValue().setVdsError(error);
Line 57: } else if (getVDSReturnValue().getVdsError().getCode()
== VdcBllErrors.VDS_NETWORK_ERROR
Line 58: || getVDSReturnValue().getVdsError().getCode()
== VdcBllErrors.VDS_CONNECTION_ERROR) {
what about other places that check for vds_network_error? if you dont add this
'or' there then you change the behavior
Line 59: log.infoFormat(
Line 60: "SpmStopVDSCommand::Could not get tasks on
vds {0} - network exception, not stopping spm! pool id {1}",
Line 61: getVds().getName(),
Line 62: getParameters().getStoragePoolId());
--
To view, visit http://gerrit.ovirt.org/20301
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icac5e6fa1d7113e6a478f6beb98066b35b2785e5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Cheryn Tan <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
