Mike Kolesnik has posted comments on this change.
Change subject: core : Moving shared fields for disks to Disk class
......................................................................
Patch Set 1: Looks good to me, approved
(2 inline comments)
Please look at inline comments
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Disk.java
Line 70: public String getinternal_drive_mapping() {
Can you please mark as deprecated, so we remember to throw this out?
Line 74: public void setinternal_drive_mapping(String value) {
same..
--
To view, visit http://gerrit.ovirt.org/3771
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia66409400fed334a8509fcfe3df33742114b4d77
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
