Arik Hadas has posted comments on this change.
Change subject: core: move network validations on run vm to RunVmValidator
......................................................................
Patch Set 8:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
Line 415: */
Line 416: protected ValidationResult isVmInterfacesConfigured(VM vm) {
Line 417: for (VmNetworkInterface nic : vm.getInterfaces()) {
Line 418: if (nic.getVnicProfileId() == null) {
Line 419: return
!FeatureSupported.networkLinking(vm.getVdsGroupCompatibilityVersion()) ?
Done
Line 420: new
ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_INTERFACE_NETWORK_NOT_CONFIGURED)
:
Line 421: ValidationResult.VALID;
Line 422: }
Line 423: }
Line 441: }
Line 442:
Line 443: // If after removing the cluster network names we still have
objects, then we have interface on networks that
Line 444: // aren't
Line 445: // attached to the cluster
Done
Line 446: return result.isEmpty() ?
Line 447: ValidationResult.VALID
Line 448: : new ValidationResult(
Line 449:
VdcBllMessages.ACTION_TYPE_FAILED_NETWORK_NOT_IN_CLUSTER,
--
To view, visit http://gerrit.ovirt.org/17971
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aff70b45617e90deac826f2a873c1604c9a4241
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
