Alon Bar-Lev has posted comments on this change.
Change subject: engine : Remove EventSubscriptionParameter
......................................................................
Patch Set 6:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserEventNotifierListModel.java
Line 303: VdcActionParametersBase params = new
VdcActionParametersBase();
Line 304: params.addParameter(GenericVdcParameter.EventSubscriber,
subscriber);
Line 305: params.addParameter(GenericVdcParameter.DomainName, domain);
Line 306: return params;
Line 307: }
not sure what this helper function saves us from.
Line 308:
Line 309: private final class EventSubscriptionFrontendActionAsyncCallback
implements IFrontendActionAsyncCallback {
Line 310: private ArrayList<VdcActionParametersBase> toAddList;
Line 311: ArrayList<VdcActionParametersBase> toRemoveList;
--
To view, visit http://gerrit.ovirt.org/20417
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e944568ac9395a141cfab3ef4d4304d1ef2d1af
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
