Kanagaraj M has posted comments on this change.

Change subject: webadmin: add dash - before every items in the remove brick 
confirmation pop up
......................................................................


Patch Set 1:

(1 comment)

....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java
Line 129:                     UICommand lastExecutedCommand) {
Line 130:                 if (lastExecutedCommand == 
getModel().getRemoveBricksCommand()) {
Line 131:                     return removeConfirmPopupProvider.get();
Line 132:                 } else {
Line 133:                     return defaultConfirmPopupProvider.get();
is this change required? doesn't super.getConfirmModelPopup resolve to the 
right confirm popup?
Line 134:                 }
Line 135:             }
Line 136: 
Line 137:         };


-- 
To view, visit http://gerrit.ovirt.org/20742
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65d43615162ea1274207e49fefcbb270d707d79c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to