Tomas Jelinek has posted comments on this change.
Change subject: webadmin: Remove NICs from VM Guide Me
......................................................................
Patch Set 1:
(5 comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java
Line 21
Line 22
Line 23
Line 24
Line 25
please delete also the corresponding constants from UiConstants
Line 21: public final String VmAddAnotherVirtualDiskAction =
ConstantsManager.getInstance()
Line 22: .getConstants()
Line 23: .vmAddAnotherVirtualDiskAction();
Line 24:
Line 25: private ArrayList<Disk> disks;
this is not needed - see my comments below
Line 26:
Line 27: @Override
Line 28: public VM getEntity()
Line 29: {
Line 45: public void onSuccess(Object target, Object
returnValue) {
Line 46: VmGuideModel vmGuideModel = (VmGuideModel)
target;
Line 47: ArrayList<Disk> disks = (ArrayList<Disk>)
returnValue;
Line 48: vmGuideModel.disks = disks;
Line 49: vmGuideModel.updateOptionsPostData();
you can just pass the disks variable to updateOptionsPostData without having a
global variable
Line 50: }
Line 51: }), getEntity().getId());
Line 52: }
Line 53:
Line 51: }), getEntity().getId());
Line 52: }
Line 53:
Line 54: private void updateOptionsPostData() {
Line 55: if (disks == null) {
I would say this check is not needed anymore.
Line 56: return;
Line 57: }
Line 58:
Line 59: // Add disk action.
Line 85: updateOptionsData();
Line 86: }
Line 87: }
Line 88:
Line 89: public void resetData() {
The whole resetData is not required anymore I would say.
Line 90: disks = null;
Line 91: }
Line 92:
Line 93: public void addDisk()
--
To view, visit http://gerrit.ovirt.org/20754
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I870e7898f788e691741bfc4bc1b24c898ab4100b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
