Liron Ar has uploaded a new change for review. Change subject: core: move vm - perform space check for relevant disks ......................................................................
core: move vm - perform space check for relevant disks The space check in the target domain should be done for the relevant disks only. Change-Id: I4812f6ad9d4d2a018df74a2e20bd66f05740032d Signed-off-by: Liron Aravot <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/57/20757/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java index 7613916..fd2f58a 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java @@ -1,5 +1,6 @@ package org.ovirt.engine.core.bll; +import java.util.Collection; import java.util.HashMap; import java.util.List; import java.util.Map; @@ -105,11 +106,11 @@ // update vm snapshots for storage free space check ImagesHandler.fillImagesBySnapshots(getVm()); - return retValue && destinationHasSpace(); + return retValue && destinationHasSpace(diskImagesToValidate); } - private boolean destinationHasSpace() { - return validate(new StorageDomainValidator(getStorageDomain()).isDomainHasSpaceForRequest((long) getVm().getActualDiskWithSnapshotsSize())); + private boolean destinationHasSpace(Collection<DiskImage> diskImages) { + return validate(new StorageDomainValidator(getStorageDomain()).isDomainHasSpaceForRequest((long) ImagesHandler.sumImagesTotalSizeWithSnapshotSize(diskImages))); } protected boolean checkTemplateInStorageDomain(List<DiskImage> diskImages) { -- To view, visit http://gerrit.ovirt.org/20757 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4812f6ad9d4d2a018df74a2e20bd66f05740032d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
