Moti Asayag has posted comments on this change.

Change subject: restapi: Add "permissions" sub-collections to vnic profiles
......................................................................


Patch Set 7:

(1 comment)

> please add:

> 1. descriptors to rsdl_metadata.yaml
Already there:
- name: /api/vnicprofiles/{vnicprofile:id}/permissions|rel=get
  description: get the list of all permissions on the virtual network interface 
card profile in the system

- name: /api/vnicprofiles/{vnicprofile:id}/permissions/{permission:id}|rel=get
  description: get details of the specified permission on the virtual network 
interface card profile in the system

> 2. a record in FeaturesHelper
We're still in 3.3, therefore the existed declaration in FeaturesHelper cover 
this case as well:

  addVnicProfilesFeature(features);

....................................................
Commit Message
Line 9: The "permissions" sub-collections is added to vnic profiles
Line 10: under the networks top collection:
Line 11: 
Line 12: api/networks/{network:id}/vnicprofiles
Line 13: api/networks/{network:id}/vnicprofiles/{profile:id}/permissions
Done
Line 14: 
Line 15: Change-Id: I02573ec87a40c7e017a24f334083044b051613ac
Line 16: Bug-Url: https://bugzilla.redhat.com/1014985


-- 
To view, visit http://gerrit.ovirt.org/20410
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02573ec87a40c7e017a24f334083044b051613ac
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to