Maor Lipchuk has posted comments on this change.
Change subject: core: RemoveVm - fix check when dettaching disks
......................................................................
Patch Set 2:
(3 comments)
....................................................
Commit Message
Line 5: CommitDate: 2013-10-31 15:16:30 +0200
Line 6:
Line 7: core: RemoveVm - fix check when dettaching disks
Line 8:
Line 9: When choosing to remove vm with attached disk snapshots and choosing to
detach it's disks,
/s/it's/its
Line 10: there's no need to check wether it's attached disk snapshots has
snapshots
Line 11: otherwise CDA message will be receieved always.
Line 12:
Line 13: Change-Id: Idae8b7ebaa17fa715812ddfc7fe9667d6085eac1
Line 6:
Line 7: core: RemoveVm - fix check when dettaching disks
Line 8:
Line 9: When choosing to remove vm with attached disk snapshots and choosing to
detach it's disks,
Line 10: there's no need to check wether it's attached disk snapshots has
snapshots
/s/wether/whether
/s/it's/its
Line 11: otherwise CDA message will be receieved always.
Line 12:
Line 13: Change-Id: Idae8b7ebaa17fa715812ddfc7fe9667d6085eac1
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
Line 242:
Line 243: return true;
Line 244: }
Line 245:
Line 246: private List<DiskImage> filtereredDiskImagesForRemoval() {
please change filterered to filtered
Line 247: return ImagesHandler.filterImageDisks(getVm().getDiskList(),
Line 248: true,
Line 249: false,
Line 250: true);
--
To view, visit http://gerrit.ovirt.org/20759
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idae8b7ebaa17fa715812ddfc7fe9667d6085eac1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
