Yaniv Bronhaim has posted comments on this change.

Change subject: packaging: setup: configure libvirt before running vdsmd
......................................................................


Patch Set 3:

(1 comment)

....................................................
File src/plugins/ovirt-hosted-engine-setup/system/vdsmenv.py
Line 117:         ):
Line 118:             rc, stdout, stderr = self.execute(
Line 119:                 (
Line 120:                     'vdsm-tool',
Line 121:                     'libvirt-is-configured',
maybe we should wait for stable vdsm-tool api ? it'll get in soon.. 
(http://gerrit.ovirt.org/#/c/20100/)
Line 122:                 ),
Line 123:                 raiseOnError=False,
Line 124:             )
Line 125:             if rc != 0:


-- 
To view, visit http://gerrit.ovirt.org/20766
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1fa427b7dacd8ed3fb6c2f059d426f9368c1d3d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to