Greg Sheremeta has posted comments on this change.
Change subject: userportal, webadmin: workaround for Firefox favicon bug
......................................................................
Patch Set 1:
(3 comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java
Line 65: // Handle UI logout requests
Line 66: user.setLogoutHandler(this);
Line 67:
Line 68: // workaround favicon-missing bug in Firefox
Line 69: registerHistoryChangeHandler();
in an offline discussion, we decided to leave this safeguard in since we don't
know all the places the FF bug can manifest
Line 70:
Line 71: // Initialize UiCommon infrastructure
Line 72: initUiCommon();
Line 73: initFrontend();
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/presenter/LoginSectionPresenter.java
Line 44: super.onReset();
Line 45:
Line 46: // work around Firefox favicon bug that appears on login screen
Line 47: FaviconRefreshUtil.refreshFavicon();
Line 48:
Done
Line 49: if (user.isLoggedIn()) {
Line 50: placeManager.revealDefaultPlace();
Line 51: } else {
Line 52: RevealRootPopupContentEvent.fire(this, loginPopup);
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/presenter/LoginSectionPresenter.java
Line 44: super.onReset();
Line 45:
Line 46: // work around Firefox favicon bug that appears on login screen
Line 47: FaviconRefreshUtil.refreshFavicon();
Line 48:
Done
Line 49: if (user.isLoggedIn()) {
Line 50: placeManager.revealDefaultPlace();
Line 51: } else {
Line 52: RevealRootPopupContentEvent.fire(this, loginPopup);
--
To view, visit http://gerrit.ovirt.org/20798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4b0d8a0176eb9299aec01ae6772297409ef3108
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
