Ravi Nori has uploaded a new change for review. Change subject: cli: Using true as a default for boolean flags(#1006918) ......................................................................
cli: Using true as a default for boolean flags(#1006918) If boolean values are not provided a value in cli they should use True by default. Change-Id: Ie87885a1219b20967241bde4e91b363355a5ea51 Bug-Url: https://bugzilla.redhat.com/1006918 Signed-off-by: Ravi Nori <[email protected]> --- M src/ovirtcli/command/command.py 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine-cli refs/changes/04/20804/1 diff --git a/src/ovirtcli/command/command.py b/src/ovirtcli/command/command.py index 9b9b6dc..0b76b57 100644 --- a/src/ovirtcli/command/command.py +++ b/src/ovirtcli/command/command.py @@ -198,6 +198,11 @@ def __set_property(self, obj, prop, val, fq_prop): """INTERNAL: set data in to property""" + if hasattr(obj, prop) and type(getattr(obj, prop)) == bool and val == None: + return + if hasattr(obj, prop + '_') and type(getattr(obj, prop + '_')) == bool and val == None: + return + if hasattr(obj, prop): setattr(obj, prop, val) elif hasattr(obj, prop + '_'): -- To view, visit http://gerrit.ovirt.org/20804 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie87885a1219b20967241bde4e91b363355a5ea51 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
