Alon Bar-Lev has posted comments on this change.
Change subject: pki: remove usage of /ca.crt uri
......................................................................
Patch Set 3:
(4 comments)
....................................................
File backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml
Line 23: <param-value>ca-certificate</param-value>
Line 24: </init-param>
Line 25: <init-param>
Line 26: <param-name>attr-format</param-name>
Line 27: <param-value>X509-PEM-CA</param-value>
will do
Line 28: </init-param>
Line 29: </servlet>
Line 30: <servlet-mapping>
Line 31: <servlet-name>PKIResourceServlet.ca</servlet-name>
Line 49: <param-value>engine-certificate</param-value>
Line 50: </init-param>
Line 51: <init-param>
Line 52: <param-name>attr-format</param-name>
Line 53: <param-value>OPENSSH-PUBKEY</param-value>
ok
Line 54: </init-param>
Line 55: </servlet>
Line 56: <servlet-mapping>
Line 57: <servlet-name>PKIResourceServlet.engine.ssh</servlet-name>
....................................................
File
backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/PKIResourceServlet.java
Line 47: EngineLocalConfig config = EngineLocalConfig.getInstance();
Line 48: pkiResources = new HashMap<String, Details>();
Line 49: pkiResources.put("ca-certificate", new
Details(config.getPKICACert(), "X509-PEM-CA"));
Line 50: pkiResources.put("engine-certificate", new
Details(config.getPKIEngineCert(), "X509-PEM", "ovirt-engine"));
Line 51: }
I created the mechanism for the LocalConfig to be available for testing... why
do we need to re-create map every instance? if you want I will do this... but I
think it is a waste of cpu time...
Line 52:
Line 53: private String getMyParameter(String name, HttpServletRequest
request) {
Line 54: String value;
Line 55:
Line 49: pkiResources.put("ca-certificate", new
Details(config.getPKICACert(), "X509-PEM-CA"));
Line 50: pkiResources.put("engine-certificate", new
Details(config.getPKIEngineCert(), "X509-PEM", "ovirt-engine"));
Line 51: }
Line 52:
Line 53: private String getMyParameter(String name, HttpServletRequest
request) {
Open to suggestions...
Line 54: String value;
Line 55:
Line 56: value = request.getParameter(name);
Line 57: if (value == null) {
--
To view, visit http://gerrit.ovirt.org/20787
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac544335e1a0c01388eae23405d83bdac4704d34
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
