Liran Zelkha has posted comments on this change.
Change subject: core, restapi: Add DbGroup
......................................................................
Patch Set 8: Code-Review+1
(3 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java
Line 242: /*
Line 243: * Vitaly workaround. Temporary treatment on missing
group domains
Line 244: */
Line 245:
Line 246: // Waiting for the GUI team to fix the ad_group class.
When the
Shouldn't this be a @TODO?
Line 247: // class is fixed,
Line 248: // domain name will be passed correctly to the backend,
and the
Line 249: // following code should not occur
Line 250: if (group.getDomain() == null &&
group.getName().contains("@")) {
Line 280:
.RunAdAction(AdActionType.GetAdGroupByGroupId,
Line 281: new
LdapSearchByIdParameters(group.getDomain(), group.getId()))
Line 282: .getReturnValue();
Line 283:
Line 284: if (group.getStatus() == 1 // Active
Don't we have a LDAP group status enum?
Line 285: && (groupFromAD == null ||
groupFromAD.getstatus() == LdapRefStatus.Inactive)) {
Line 286: group.setStatus(0); // Inactive
Line 287: } else if (groupFromAD != null
Line 288: &&
(!StringUtils.equals(group.getName(), groupFromAD.getname())
....................................................
File
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/ADSyntaxChecker.java
Line 280: private static String
generateAdQueryFromSyntaxContainer(SyntaxContainer syntax) {
Line 281: StringBuilder retval = new StringBuilder();
Line 282: if (syntax.getvalid()) {
Line 283: IConditionFieldAutoCompleter conditionFieldAC;
Line 284: final boolean isUsersQuery =
syntax.getSearchObjectStr().contains("ADUSER");
I suggest all Active Directory filter related strings should exist in the
database, so we can easily change it for other LDAP servers, or for customers
that have different parameters.
Line 285: if (isUsersQuery) {
Line 286: retval.append("(&");
Line 287: retval.append("(" + USER_ACCOUNT_TYPE + ")");
Line 288: conditionFieldAC = new
AdUserConditionFieldAutoCompleter();
--
To view, visit http://gerrit.ovirt.org/17544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb1a7146c29eb74f97e10043d65b5a67f1430021
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
