Omer Frenkel has posted comments on this change.

Change subject: core: fix of export without tasks and snapshot collapse
......................................................................


Patch Set 6:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
Line 509:             endCopyCollapseOperations(vm);
Line 510:         } else {
Line 511:             updateSnapshotOvf(vm);
Line 512:         }
Line 513:         VmHandler.unLockVm(vm);
are you sure endCopyCollapseOperations or something else was relaying on the 
fact that the vm is not locked anymore?
Line 514:         setSucceeded(true);
Line 515:     }
Line 516: 
Line 517:     private void populateVmData(VM vm) {


-- 
To view, visit http://gerrit.ovirt.org/20712
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1bfc2761a5483d6f0b274d064cbc7e155562573f
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to