Alissa Bonas has uploaded a new change for review. Change subject: core: rename methods to lowercase in BrokerCommandBase ......................................................................
core: rename methods to lowercase in BrokerCommandBase Change-Id: I8a765db49e4a3c9a93e7d118fedd29b31e157383 Signed-off-by: Alissa Bonas <[email protected]> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/DetachStorageDomainVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/ExtendStorageDomainVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImageInfoVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetVolumesListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/RemoveVMVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/UpdateVMVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/AddNetworkVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CancelMigrateVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStoragePoolVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateStoragePoolVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMClearTaskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetTaskStatusVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMRevertTaskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStatusVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStopVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java 19 files changed, 25 insertions(+), 25 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/26/20826/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java index 2102242..4248155 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java @@ -16,7 +16,7 @@ @Override protected void proceedProxyReturnValue() { - VdcBllErrors returnStatus = GetReturnValueFromStatus(getReturnStatus()); + VdcBllErrors returnStatus = getReturnValueFromStatus(getReturnStatus()); switch (returnStatus) { case GlusterGeneralException: case GlusterPermissionDeniedException: diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/DetachStorageDomainVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/DetachStorageDomainVDSCommand.java index 0cfa149..a65b727 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/DetachStorageDomainVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/DetachStorageDomainVDSCommand.java @@ -18,7 +18,7 @@ getParameters().getStoragePoolId().toString()); proceedProxyReturnValue(); } catch (RuntimeException ex) { - PrintReturnValue(); + printReturnValue(); log.errorFormat("Could not force detach domain {0} on pool {1}. error: {2}", getParameters() .getStorageDomainId(), getParameters().getStoragePoolId(), ex.toString()); getVDSReturnValue().setSucceeded(false); diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/ExtendStorageDomainVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/ExtendStorageDomainVDSCommand.java index c5f619b..fc84831 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/ExtendStorageDomainVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/ExtendStorageDomainVDSCommand.java @@ -28,7 +28,7 @@ @Override protected void proceedProxyReturnValue() { - VdcBllErrors returnStatus = GetReturnValueFromStatus(getReturnStatus()); + VdcBllErrors returnStatus = getReturnValueFromStatus(getReturnStatus()); switch (returnStatus) { case DeviceNotFound: getVDSReturnValue().setSucceeded(false); diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImageInfoVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImageInfoVDSCommand.java index 7613ade..01646e8 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImageInfoVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImageInfoVDSCommand.java @@ -40,7 +40,7 @@ proceedProxyReturnValue(); di = buildImageEntity(imageInfoReturn.mInfo); } catch (java.lang.Exception e) { - PrintReturnValue(); + printReturnValue(); // nothing to do - logging inside upper functions } finally { // if couldn't parse image then succeeded should be false @@ -56,7 +56,7 @@ @Override protected void proceedProxyReturnValue() { - VdcBllErrors returnStatus = GetReturnValueFromStatus(getReturnStatus()); + VdcBllErrors returnStatus = getReturnValueFromStatus(getReturnStatus()); if (returnStatus != VdcBllErrors.Done) { log.errorFormat( "IrsBroker::getImageInfo::Failed getting image info imageId = {0} does not exist on domainName = {1} , domainId = {2}, error code: {3}, message: {4}", @@ -118,7 +118,7 @@ } } catch (RuntimeException ex) { log.errorFormat("irsBroker::buildImageEntity::Failed building DIskImage"); - PrintReturnValue(); + printReturnValue(); log.error(ex.getMessage(), ex); newImage = null; } diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetVolumesListVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetVolumesListVDSCommand.java index 695526e..5e2c30a 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetVolumesListVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetVolumesListVDSCommand.java @@ -41,7 +41,7 @@ @Override protected void proceedProxyReturnValue() { - VdcBllErrors returnStatus = GetReturnValueFromStatus(getReturnStatus()); + VdcBllErrors returnStatus = getReturnValueFromStatus(getReturnStatus()); switch (returnStatus) { case GetStorageDomainListError: getVDSReturnValue().setVdsError(new VDSError(returnStatus, getReturnStatus().mMessage)); diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/RemoveVMVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/RemoveVMVDSCommand.java index e11675a..3cffa21 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/RemoveVMVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/RemoveVMVDSCommand.java @@ -26,7 +26,7 @@ @Override protected void proceedProxyReturnValue() { - VdcBllErrors returnStatus = GetReturnValueFromStatus(getReturnStatus()); + VdcBllErrors returnStatus = getReturnValueFromStatus(getReturnStatus()); switch (returnStatus) { case Done: return; diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/UpdateVMVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/UpdateVMVDSCommand.java index ea0a7fd..8987881 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/UpdateVMVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/UpdateVMVDSCommand.java @@ -52,7 +52,7 @@ @Override protected void proceedProxyReturnValue() { - VdcBllErrors returnStatus = GetReturnValueFromStatus(getReturnStatus()); + VdcBllErrors returnStatus = getReturnValueFromStatus(getReturnStatus()); switch (returnStatus) { case Done: return; diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/AddNetworkVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/AddNetworkVDSCommand.java index c4e6e7c..a00b6ac 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/AddNetworkVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/AddNetworkVDSCommand.java @@ -77,7 +77,7 @@ // 3.1. If the timeout was a failure to call the VDSM in the first place, then probably the call to delete // the network will timeout also. if (getReturnValueFromBroker() == null || - VdcBllErrors.Done == GetReturnValueFromStatus(getReturnStatus())) { + VdcBllErrors.Done == getReturnValueFromStatus(getReturnStatus())) { String network = (getParameters().getNetworkName() == null) ? "" : getParameters() .getNetworkName(); String vlanId = (getParameters().getVlanId() != null) ? getParameters().getVlanId() diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java index cdfdd99..e35b645 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java @@ -33,7 +33,7 @@ } protected void proceedProxyReturnValue() { - VdcBllErrors returnStatus = GetReturnValueFromStatus(getReturnStatus()); + VdcBllErrors returnStatus = getReturnValueFromStatus(getReturnStatus()); VDSExceptionBase outEx; switch (returnStatus) { case Done: @@ -201,7 +201,7 @@ protected abstract VDSExceptionBase createDefaultConcreteException(String errorMessage); - protected VdcBllErrors GetReturnValueFromStatus(StatusForXmlRpc xmlRpcStatus) { + protected VdcBllErrors getReturnValueFromStatus(StatusForXmlRpc xmlRpcStatus) { try { VdcBllErrors bllErrors = VdcBllErrors.forValue(xmlRpcStatus.mCode); if (bllErrors == null) { @@ -227,7 +227,7 @@ } @SuppressWarnings("unchecked") - protected void PrintReturnValue() { + protected void printReturnValue() { if (getReturnValueFromBroker() != null && getIsPrintReturnValue()) { String returnValue; StringBuilder builder = new StringBuilder(); diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CancelMigrateVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CancelMigrateVDSCommand.java index a080c98..88b8daf 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CancelMigrateVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CancelMigrateVDSCommand.java @@ -25,7 +25,7 @@ */ @Override protected void proceedProxyReturnValue() { - VdcBllErrors returnStatus = GetReturnValueFromStatus(getReturnStatus()); + VdcBllErrors returnStatus = getReturnValueFromStatus(getReturnStatus()); switch (returnStatus) { case noVM: VDSExceptionBase outEx = diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStoragePoolVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStoragePoolVDSCommand.java index 4328e5e..efbea46 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStoragePoolVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStoragePoolVDSCommand.java @@ -21,7 +21,7 @@ // master domain failure treatment @Override protected void proceedProxyReturnValue() { - VdcBllErrors returnStatus = GetReturnValueFromStatus(getReturnStatus()); + VdcBllErrors returnStatus = getReturnValueFromStatus(getReturnStatus()); switch (returnStatus) { case Done: case StoragePoolMasterNotFound: diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java index 56b9056..aa4cbd5 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java @@ -39,7 +39,7 @@ @Override protected void proceedProxyReturnValue() { - VdcBllErrors returnStatus = GetReturnValueFromStatus(getReturnStatus()); + VdcBllErrors returnStatus = getReturnValueFromStatus(getReturnStatus()); switch (returnStatus) { case StorageServerConnectionRefIdAlreadyInUse: case StorageServerConnectionRefIdDoesNotExist: diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateStoragePoolVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateStoragePoolVDSCommand.java index 24c470a..f84140f 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateStoragePoolVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateStoragePoolVDSCommand.java @@ -33,7 +33,7 @@ @Override protected void proceedProxyReturnValue() { - VdcBllErrors returnStatus = GetReturnValueFromStatus(getReturnStatus()); + VdcBllErrors returnStatus = getReturnValueFromStatus(getReturnStatus()); switch (returnStatus) { // fail the operation without throwing exception case StorageDomainAccessError: diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMClearTaskVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMClearTaskVDSCommand.java index 7db4637..1975a8d 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMClearTaskVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMClearTaskVDSCommand.java @@ -16,7 +16,7 @@ @Override protected void proceedProxyReturnValue() { - VdcBllErrors returnStatus = GetReturnValueFromStatus(getReturnStatus()); + VdcBllErrors returnStatus = getReturnValueFromStatus(getReturnStatus()); switch (returnStatus) { case UnknownTask: diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetTaskStatusVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetTaskStatusVDSCommand.java index 2693d28..54136dc 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetTaskStatusVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetTaskStatusVDSCommand.java @@ -23,7 +23,7 @@ @Override protected void proceedProxyReturnValue() { - VdcBllErrors returnStatus = GetReturnValueFromStatus(getReturnStatus()); + VdcBllErrors returnStatus = getReturnValueFromStatus(getReturnStatus()); switch (returnStatus) { case UnknownTask: // ignore this, the parser can handle the empty result. diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMRevertTaskVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMRevertTaskVDSCommand.java index 0d2b264..9c3389a 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMRevertTaskVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMRevertTaskVDSCommand.java @@ -16,7 +16,7 @@ @Override protected void proceedProxyReturnValue() { - VdcBllErrors returnStatus = GetReturnValueFromStatus(getReturnStatus()); + VdcBllErrors returnStatus = getReturnValueFromStatus(getReturnStatus()); switch (returnStatus) { case UnknownTask: diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStatusVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStatusVDSCommand.java index 2f247b5..ad1809d 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStatusVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStatusVDSCommand.java @@ -33,7 +33,7 @@ @Override protected void proceedProxyReturnValue() { - VdcBllErrors returnStatus = GetReturnValueFromStatus(getReturnStatus()); + VdcBllErrors returnStatus = getReturnValueFromStatus(getReturnStatus()); switch (returnStatus) { case StoragePoolUnknown: // ignore this, the parser can handle the empty result. diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStopVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStopVDSCommand.java index f844f58..032e4c8 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStopVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStopVDSCommand.java @@ -95,7 +95,7 @@ @Override protected void proceedProxyReturnValue() { - VdcBllErrors returnStatus = GetReturnValueFromStatus(getReturnStatus()); + VdcBllErrors returnStatus = getReturnValueFromStatus(getReturnStatus()); switch (returnStatus) { case StoragePoolUnknown: case SpmStatusError: diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java index 8a9b03f..bd32ad0 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java @@ -95,19 +95,19 @@ try { executeVdsBrokerCommand(); } catch (VDSExceptionBase ex) { - PrintReturnValue(); + printReturnValue(); throw ex; } catch (XmlRpcRunTimeException ex) { Throwable rootCause = ExceptionUtils.getRootCause(ex); VDSNetworkException networkException = new VDSNetworkException(rootCause); networkException.setVdsError(new VDSError(VdcBllErrors.VDS_NETWORK_ERROR, rootCause.toString())); - PrintReturnValue(); + printReturnValue(); throw networkException; } // TODO: look for invalid certificates error handling catch (RuntimeException e) { - PrintReturnValue(); + printReturnValue(); if (getAndSetVdsStatic() == null) { log.errorFormat("Failed in {0} method, for vds id: {1}", getCommandName(), getParameters().getVdsId()); -- To view, visit http://gerrit.ovirt.org/20826 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8a765db49e4a3c9a93e7d118fedd29b31e157383 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
