Allon Mureinik has posted comments on this change.
Change subject: core: fix methods in IrsBrokerCommand to lowercase
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 94: * @param storagePoolId
Line 95: * @param vdsDomainData
Line 96: */
Line 97: public static void updateVdsDomainsData(VDS vds, Guid
storagePoolId,
Line 98: ArrayList<VDSDomainsData>
vdsDomainData) {
Unrelated (and probably wrong according to our formatter)
Line 99: if (vds.getStatus() == VDSStatus.Up) {
Line 100: IrsProxyData proxy = _irsProxyData.get(storagePoolId);
Line 101: if (proxy != null) {
Line 102: proxy.updateVdsDomainsData(vds.getId(),
vds.getName(), vdsDomainData);
Line 1005: private final Map<Guid, HashSet<Guid>> _domainsInProblem =
new ConcurrentHashMap<Guid, HashSet<Guid>>();
Line 1006: private final Map<Guid, String> _timers = new HashMap<Guid,
String>();
Line 1007:
Line 1008: public void updateVdsDomainsData(final Guid vdsId, final
String vdsName,
Line 1009: final
ArrayList<VDSDomainsData> data) {
Unrelated (and probably wrong according to our formatter)
Line 1010:
Line 1011: Set<Guid> domainsInProblems = null;
Line 1012: StoragePool storagePool =
Line 1013:
DbFacade.getInstance().getStoragePoolDao().get(_storagePoolId);
--
To view, visit http://gerrit.ovirt.org/20824
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice0db54b1fece642cc5fee395e0652b55b34ced7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
