Michael Pasternak has posted comments on this change. Change subject: restapi : Using true as a default for boolean flags(#1006918) ......................................................................
Patch Set 1: Code-Review-2 (3 comments) .................................................... Commit Message Line 3: AuthorDate: 2013-11-01 12:10:57 -0400 Line 4: Commit: Ravi Nori <[email protected]> Line 5: CommitDate: 2013-11-01 12:10:57 -0400 Line 6: Line 7: restapi : Using true as a default for boolean flags(#1006918) this is wrong and braking backward compatibility, also schema should not dictate default values to the engine .... Line 8: Line 9: If boolean values are not provided a value Line 10: in cli they should use True by default. Line 11: Line 6: Line 7: restapi : Using true as a default for boolean flags(#1006918) Line 8: Line 9: If boolean values are not provided a value Line 10: in cli they should use True by default. 1. action.asyn is not only boolean in the api .... 2. this is cli RFE that should be fixed in CLI without effecting api and all it consumers Line 11: Line 12: Change-Id: I823d4cbaa22cabe2c73b64be17dfe70233f7cd01 Line 13: Bug-Url: https://bugzilla.redhat.com/1006918 .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd Line 171: <xs:element name="connectivity_timeout" type="xs:int" minOccurs="0"/> Line 172: <!-- A VM can be started paused --> Line 173: <xs:element name="pause" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Line 174: <!-- should migration be forced if VM is pinned to host? --> Line 175: <xs:element name="force" type="xs:boolean" minOccurs="0" default="true" /> this is wrong and braking backward compatibility, also schema should not dictate default values to the engine .... Line 176: <!-- For gluster volume set/reset option action --> Line 177: <xs:element name="option" type="Option" minOccurs="0"/> Line 178: <!-- In gluster volume rebalance action, should only fix-layout be performed --> Line 179: <xs:element name="fix_layout" type="xs:boolean" minOccurs="0"/> -- To view, visit http://gerrit.ovirt.org/20805 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I823d4cbaa22cabe2c73b64be17dfe70233f7cd01 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
