Martin Peřina has posted comments on this change.

Change subject: core: Unifies testing devices are disks
......................................................................


Patch Set 2:

(2 comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
Line 997:     }
Line 998: 
Line 999:     private static boolean isDiskOrInterface(VmDevice vmDevice) {
Line 1000:         return VmDeviceCommonUtils.isDisk(vmDevice) ||
Line 1001:         (vmDevice.getDevice().equals(VmDeviceType.BRIDGE.getName())
This change is contained in bridges patch 18159
Line 1002:                 && vmDevice.getType() == 
VmDeviceGeneralType.INTERFACE);
Line 1003:     }
Line 1004: 
Line 1005:     public static boolean isVirtioScsiControllerAttached(Guid vmId) {


....................................................
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 1160:     }
Line 1161: 
Line 1162:     private boolean devicePluggable(VmDevice device) {
Line 1163:         return VmDeviceCommonUtils.isDisk(device)
Line 1164:                 || 
(VmDeviceType.BRIDGE.getName().equals(device.getDevice())
Sorry, please ignore my previous response.

This change is contained in bridges patch 18159
Line 1165:                 && VmDeviceGeneralType.INTERFACE == 
device.getType());
Line 1166:     }
Line 1167: 
Line 1168:     /**


-- 
To view, visit http://gerrit.ovirt.org/18158
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2678f10e4ef8911e3d59bb9bae69a6eba822895
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to