Liran Zelkha has posted comments on this change.

Change subject: core: Inject Config instance to CommandBase
......................................................................


Patch Set 7:

(1 comment)

Quick question - how are we handling weld with JUnit? I didn't see junit code 
here :-(

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/Config.java
Line 11: 
Line 12:     private Config() {
Line 13:     }
Line 14: 
Line 15:     public static IConfigUtilsInterface getConfigUtils() {
Can't this be injected too?
Line 16:         return _configUtils;
Line 17:     }
Line 18: 
Line 19:     public static void setConfigUtils(IConfigUtilsInterface value) {


-- 
To view, visit http://gerrit.ovirt.org/17613
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42517ed27b29bc91ffe5062ada651a1d5eb07bed
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Martin PeÅ™ina <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to