Lior Vernia has uploaded a new change for review. Change subject: webadmin: Fix visual regression in Setup Networks ......................................................................
webadmin: Fix visual regression in Setup Networks When refactoring I caused the required/non-required labels to disappear, this fixes it. Change-Id: If6ca63f1140c5519425fac7910a35127f367da4b Bug-Url: https://bugzilla.redhat.com/1026225 Signed-off-by: Lior Vernia <[email protected]> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/InternalNetworksPanel.java 1 file changed, 15 insertions(+), 9 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/55/20855/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/InternalNetworksPanel.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/InternalNetworksPanel.java index 17df96a..5553bf2 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/InternalNetworksPanel.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/InternalNetworksPanel.java @@ -11,9 +11,11 @@ public class InternalNetworksPanel extends UnassignedNetworksPanel { - private VerticalPanel requiredPanel = new VerticalPanel(); - private VerticalPanel nonRequiredPanel = new VerticalPanel(); + private final VerticalPanel requiredPanel = new VerticalPanel(); + private final VerticalPanel nonRequiredPanel = new VerticalPanel(); private final List<VerticalPanel> unassignNetworksList = new ArrayList<VerticalPanel>(); + private SimplePanel requiredTitlePanel; + private SimplePanel nonRequiredTitlePanel; public InternalNetworksPanel() { unassignNetworksList.add(requiredPanel); @@ -23,24 +25,28 @@ @Override public void setStyle(final NetworkPanelsStyle style) { super.setStyle(style); - stylePanel(requiredPanel, constants.requiredNetwork()); - stylePanel(nonRequiredPanel, constants.nonRequiredNetwork()); + + stylePanel(requiredPanel); + stylePanel(nonRequiredPanel); + + requiredTitlePanel = initTitlePanel(constants.requiredNetwork()); + nonRequiredTitlePanel = initTitlePanel(constants.nonRequiredNetwork()); } - private void stylePanel(VerticalPanel panel, String title) { + private SimplePanel initTitlePanel(String title) { Label label = new Label(title); - SimplePanel titlePanel = new SimplePanel(new Label(title)); + SimplePanel titlePanel = new SimplePanel(label); titlePanel.setStyleName(style.requiredTitlePanel()); label.getElement().addClassName(style.requiredLabel()); - panel.add(titlePanel); - - super.stylePanel(panel); + return titlePanel; } @Override public void addAll(List<NetworkPanel> list, boolean fadeIn) { + requiredPanel.add(requiredTitlePanel); + nonRequiredPanel.add(nonRequiredTitlePanel); for (NetworkPanel networkPanel : list) { LogicalNetworkModel networkModel = (LogicalNetworkModel) networkPanel.getItem(); boolean isRequired = -- To view, visit http://gerrit.ovirt.org/20855 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If6ca63f1140c5519425fac7910a35127f367da4b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
