Tomas Jelinek has posted comments on this change.
Change subject: frontend: Control virtio rng device
......................................................................
Patch Set 6:
(1 comment)
just a minor comment - otherwise seems ok
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
Line 1384: * integer, null or nfexception
Line 1385: * @param s
Line 1386: * @return
Line 1387: */
Line 1388: private static Integer parseIntOrNull(String s) {
I don't see this method called - please remove
Line 1389: if (s == null) {
Line 1390: return null;
Line 1391: }
Line 1392:
--
To view, visit http://gerrit.ovirt.org/18497
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffbc48062f25d90795bc360362f42cd1042fb888
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
