Arik Hadas has uploaded a new change for review.
Change subject: core: fix log message about rerun a vm
......................................................................
core: fix log message about rerun a vm
We used to have log message saying "vm {0} running in db and not running
in vds - add to rerun treatment" for each vm that was set as running in the
engine and reported as one that is not running by vdsm, even in cases where
we didn't add it to the 'rerun treatment' later on.
This patch change this logging message - now we log a message that just
say that the vm is running in db and not in vds in that case, and we log
another message saying that the vm is added to rerun treatment when it
is actually added to the 'rerun treatment'.
Change-Id: Icc2940845d150fcd41e7e327769f50c8bfffce5e
Signed-off-by: Arik Hadas <[email protected]>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/83/20883/1
diff --git
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
index 6428e90..8edd0c2 100644
---
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
+++
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
@@ -1734,18 +1734,20 @@
isInMigration = true;
handOverVM(vmToRemove);
} else {
+ log.infoFormat("VM {0} ({1}) is running in db and not running
in VDS {2}",
+ vmToRemove.getName(), vmToRemove.getId(),
_vds.getName());
+
clearVm(vmToRemove,
VmExitStatus.Error,
String.format("Could not find VM %s on host, assuming
it went down unexpectedly",
vmToRemove.getName()));
}
- log.infoFormat("vm {0} running in db and not running in vds - add
to rerun treatment. vds {1}",
- vmToRemove.getName(), _vds.getName());
vmGuid = vmToRemove.getId();
if (!isInMigration && !_vmsToRerun.contains(vmGuid)
&&
ResourceManager.getInstance().IsVmInAsyncRunningList(vmGuid)) {
_vmsToRerun.add(vmGuid);
+ log.infoFormat("add VM {0} to rerun treatment",
vmToRemove.getName());
}
// vm should be auto startup
// not already in start up list
@@ -1757,6 +1759,7 @@
.getVmDynamic()
.getExitStatus() != VmExitStatus.Normal))) {
_autoVmsToRun.add(vmGuid);
+ log.infoFormat("add VM {0} to HA rerun treatment",
vmToRemove.getName());
}
}
}
--
To view, visit http://gerrit.ovirt.org/20883
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc2940845d150fcd41e7e327769f50c8bfffce5e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
