Sergey Gotliv has posted comments on this change.
Change subject: backend: check image status before ExportRepoImage
......................................................................
Patch Set 1:
(2 comments)
Why -1?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportRepoImageCommand.java
Line 236: }
Line 237: }
Line 238:
Line 239: DiskImagesValidator diskImagesValidator = new
DiskImagesValidator(Arrays.asList(getDiskImage()));
Line 240: if (!validate(diskImagesValidator.diskImagesNotIllegal())
Another patch, I guess that this rename will have a direct inpact on many many
many :-) classes
Line 241: ||
!validate(diskImagesValidator.diskImagesNotLocked())) {
Line 242: return false;
Line 243: }
Line 244:
Line 237: }
Line 238:
Line 239: DiskImagesValidator diskImagesValidator = new
DiskImagesValidator(Arrays.asList(getDiskImage()));
Line 240: if (!validate(diskImagesValidator.diskImagesNotIllegal())
Line 241: ||
!validate(diskImagesValidator.diskImagesNotLocked())) {
Ayal,
1. Suggested changes are not the part of this patch because validator with
these crazy :-) names was introduced a long time ago.
2. 'Locked' is the status of entity in database. In memory lock is already
obtained before the CDA, otherwise you can't count on validity of checking in
the CDA.
Line 242: return false;
Line 243: }
Line 244:
Line 245: return true;
--
To view, visit http://gerrit.ovirt.org/20871
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0957a05db4a0fdcddf56a63b0a3da0b4d27db6d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
