Martin Sivák has posted comments on this change. Change subject: core: Remove support for ib700 watchdog ......................................................................
Patch Set 1: Changing the empty string (no watchdog) to something else will unfortunately introduce quite ugly tech. debt, because we use the strings directly to get enum values. Our representation uses list of string that representboth the value and the key.. until this is changed we can't easily mix real (enum) and virtual (null) values in a single combobox model. -- To view, visit http://gerrit.ovirt.org/20035 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83242f3ccd7c2fc6ed7c4321ecaa89fca0140093 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eoghan Glynn <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <[email protected]> Gerrit-Reviewer: Leonardo Bianconi <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Noam Slomianko <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
