Darshan N has uploaded a new change for review. Change subject: gluster:Hide irrelevant fields in configuration preview during setup ......................................................................
gluster:Hide irrelevant fields in configuration preview during setup Few fields like NFS setup, Application mode and Datacentre storage type are not relevant when application mode is gluster. So they will not be displayed under configuration preview during engine-setup if application mode is gluster. bug url: https://bugzilla.redhat.com/show_bug.cgi?id=1020190 Signed-off-by: ndarshan <[email protected]> Change-Id: I9e4b3fffd37a62d9fc551dff178d5662d610ddd4 --- M packaging/setup/plugins/ovirt-engine-setup/dialog/preview.py 1 file changed, 13 insertions(+), 10 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/55/20955/1 diff --git a/packaging/setup/plugins/ovirt-engine-setup/dialog/preview.py b/packaging/setup/plugins/ovirt-engine-setup/dialog/preview.py index 1aa8bb3..e826738 100644 --- a/packaging/setup/plugins/ovirt-engine-setup/dialog/preview.py +++ b/packaging/setup/plugins/ovirt-engine-setup/dialog/preview.py @@ -62,17 +62,20 @@ if attrs['summary']: env = k.fget(None) value = self.environment.get(env) - if value is not None: - self.dialog.note( - text=_('{key:35}: {value}').format( - key=( - attrs['description'] - if attrs['description'] is not None - else env + fld = attrs['description'] if attrs['description'] is not None else env + if(self.environment[osetupcons.ConfigEnv.APPLICATION_MODE] != 'gluster' or \ + (fld != 'NFS setup' and fld !='Application mode' and fld !='Datacenter storage type' )): + if value is not None: + self.dialog.note( + text=_('{key:35}: {value}').format( + key=( + attrs['description'] + if attrs['description'] is not None + else env + ), + value=value, ), - value=value, - ), - ) + ) confirmed = self.environment[ osetupcons.DialogEnv.CONFIRM_SETTINGS -- To view, visit http://gerrit.ovirt.org/20955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9e4b3fffd37a62d9fc551dff178d5662d610ddd4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Darshan N <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
