Sandro Bonazzola has posted comments on this change.

Change subject: packaging: setup: check database object ownership on upgrade
......................................................................


Patch Set 2:

(2 comments)

....................................................
File packaging/setup/plugins/ovirt-engine-setup/db/schema.py
Line 137:                 server=self.environment[osetupcons.DBEnv.HOST],
Line 138:                 port=self.environment[osetupcons.DBEnv.PORT],
Line 139:                 db=self.environment[osetupcons.DBEnv.DATABASE],
Line 140:                 user=self.environment[osetupcons.DBEnv.USER],
Line 141:             )
I prefer to avoid to have command options in a .po file :-)
Line 142: 
Line 143:             raise RuntimeError(
Line 144:                 _(
Line 145:                     'Cannot upgrade the database schema due to wrong '


Line 147:                     'Please execute: {command}\n'
Line 148:                     'Using password: {password}'
Line 149:                 ).format(
Line 150:                     command=command,
Line 151:                     
password=self.environment[osetupcons.DBEnv.PASSWORD],
Done
Line 152:                 )
Line 153:             )
Line 154: 
Line 155:     def _checkSupportedVersionsPresent(self):


-- 
To view, visit http://gerrit.ovirt.org/20935
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I45b655e88c25dd51e567405cc6747b42dfd8a98b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to