Lior Vernia has uploaded a new change for review. Change subject: webadmin: Small fix to VnicProfilesEditor ......................................................................
webadmin: Small fix to VnicProfilesEditor As all the changes in the profiles are committed to the model as soon as they happen (adding/removing rows, typing characters) it's unnecessary to flush the widget; it also causes a ghost row to be added the moment "OK" is pressed, so it would be better to avoid this flicker. Also added some javadoc to prevent usage of a method. Change-Id: I504ebef37ef6e3d259cdea8d766a64b4aec51930 Signed-off-by: Lior Vernia <[email protected]> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/NewNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/EditNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.java 3 files changed, 7 insertions(+), 9 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/82/20982/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/NewNetworkPopupView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/NewNetworkPopupView.java index 9ab5ad7..7c47593 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/NewNetworkPopupView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/NewNetworkPopupView.java @@ -46,9 +46,7 @@ @Override public NewNetworkModel flush() { - NewNetworkModel model = driver.flush(); - model.getProfiles().setItems(profilesEditor.flush().getItems()); - return model; + return driver.flush(); } @Override diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/EditNetworkPopupView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/EditNetworkPopupView.java index 21521dd..2597954 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/EditNetworkPopupView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/EditNetworkPopupView.java @@ -49,9 +49,7 @@ @Override public EditNetworkModel flush() { - EditNetworkModel model = driver.flush(); - model.getProfiles().setItems(profilesEditor.flush().getItems()); - return model; + return driver.flush(); } } diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.java index c00ec29..9529d8c 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.java @@ -45,15 +45,17 @@ init(model); } + /** + * @deprecated Please use {@link #edit(ListModel, Version, Guid, VnicProfileModel)} instead. + **/ + @Deprecated @Override public void edit(ListModel model) { edit(model, dcCompatibilityVersion, dcId, defaultProfile); } public ListModel flush() { - ListModel model = driver.flush(); - flush(model); - return model; + return driver.flush(); } @Override -- To view, visit http://gerrit.ovirt.org/20982 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I504ebef37ef6e3d259cdea8d766a64b4aec51930 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
