Federico Simoncelli has uploaded a new change for review. Change subject: core: add testCanDoActionImageLocked for ExportRepoImage ......................................................................
core: add testCanDoActionImageLocked for ExportRepoImage Change-Id: Ie5987cddb5e0a9bb8f9beb9ce765ed83f927671b Signed-off-by: Federico Simoncelli <[email protected]> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ExportRepoImageCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportExportRepoImageCommandTest.java 2 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/92/20992/1 diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ExportRepoImageCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ExportRepoImageCommandTest.java index e533a41..69cac6c 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ExportRepoImageCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ExportRepoImageCommandTest.java @@ -6,6 +6,7 @@ import org.mockito.Mock; import org.mockito.runners.MockitoJUnitRunner; import org.ovirt.engine.core.common.action.ExportRepoImageParameters; +import org.ovirt.engine.core.common.businessentities.ImageStatus; import org.ovirt.engine.core.common.businessentities.StorageDomainStatus; import org.ovirt.engine.core.common.businessentities.VM; import org.ovirt.engine.core.common.businessentities.VMStatus; @@ -86,4 +87,10 @@ VdcBllMessages.ACTION_TYPE_FAILED_VM_IS_RUNNING); } + @Test + public void testCanDoActionImageLocked() { + getDiskImage().setImageStatus(ImageStatus.LOCKED); + CanDoActionTestUtils.runAndAssertCanDoActionFailure(cmd, + VdcBllMessages.ACTION_TYPE_FAILED_DISKS_LOCKED); + } } diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportExportRepoImageCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportExportRepoImageCommandTest.java index 45a7e58..d8fbfba 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportExportRepoImageCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportExportRepoImageCommandTest.java @@ -6,6 +6,7 @@ import org.ovirt.engine.core.bll.lock.InMemoryLockManager; import org.ovirt.engine.core.bll.provider.OpenStackImageProviderProxy; import org.ovirt.engine.core.common.businessentities.DiskImage; +import org.ovirt.engine.core.common.businessentities.ImageStatus; import org.ovirt.engine.core.common.businessentities.Provider; import org.ovirt.engine.core.common.businessentities.ProviderType; import org.ovirt.engine.core.common.businessentities.StorageDomain; @@ -157,6 +158,7 @@ diskImage.setId(diskImageId); diskImage.setStorageIds(new ArrayList<>(Arrays.asList(storageDomainId))); diskImage.setStoragePoolId(storagePoolId); + diskImage.setImageStatus(ImageStatus.OK); when(storageDomainDao.get(repoStorageDomainId)).thenReturn(imageStorageDomain); when(storageDomainDao.getAllForStorageDomain(storageDomainId)) -- To view, visit http://gerrit.ovirt.org/20992 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie5987cddb5e0a9bb8f9beb9ce765ed83f927671b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
