Douglas Schilling Landgraf has uploaded a new change for review.

Change subject: engine_page: fix logic to show fingerprint msg
......................................................................

engine_page: fix logic to show fingerprint msg

Show fingerprint review message only when there is fingerprint.

Change-Id: I30f4d8657f196ecdd23ff7d5e8ebdfbdca764963
Signed-off-by: Douglas Schilling Landgraf <[email protected]>
---
M src/engine_page.py
1 file changed, 7 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node-plugin-vdsm 
refs/changes/01/21001/1

diff --git a/src/engine_page.py b/src/engine_page.py
index ca1098b..e4c498e 100644
--- a/src/engine_page.py
+++ b/src/engine_page.py
@@ -121,16 +121,17 @@
                 self._cert_path, fingerprint = retrieveCetrificate(server,
                                                                    port)
                 self._server, self._port = server, port
+                title_msg = "\nPlease review the following SSL fingerprint" \
+                            " from Engine:\n"
             except Exception as e:
                 fingerprint = str(e)
+                title_msg = "\n"
                 buttons = [ui.Button("action.cert.reject", "Close")]
 
-            self._fp_dialog = ui.Dialog("dialog.engine.fp",
-                "{engine_name} Fingerprint".format(
-                    engine_name=config.engine_name),
-                    [ui.Label("dialog.label[0]",
-                    "\nPlease review the following fingerprint from 
Engine:\n"),
-                    ui.Label("dialog.fp", fingerprint)])
+            self._fp_dialog = ui.Dialog("dialog.engine.fp", "{engine_name} "
+                                        
"Fingerprint".format(engine_name=config.engine_name),
+                                        [ui.Label("dialog.label[0]", 
title_msg),
+                                        ui.Label("dialog.fp", fingerprint)])
 
             self._fp_dialog.buttons = buttons
             return self._fp_dialog


-- 
To view, visit http://gerrit.ovirt.org/21001
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I30f4d8657f196ecdd23ff7d5e8ebdfbdca764963
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: node-3.0
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to