Sahina Bose has posted comments on this change.
Change subject: gluster: Modified to fail remove host if already removed from
CLI
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java
Line 46: */
Line 47: if (isGlusterEnabled() && upServer != null) {
Line 48: glusterHostRemove();
Line 49: if (!getSucceeded()) {
Line 50: return;
What about the case where this is the last host being removed?
In this case, clusterHasMultipleHosts returns false, and "gluster peer detach"
is not executed. Will getSucceeded() return true in this case?
Line 51: }
Line 52: }
Line 53:
Line 54: /**
--
To view, visit http://gerrit.ovirt.org/20655
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e8c79bcbf9c3dc733641812f505170e369448a1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
