Yair Zaslavsky has posted comments on this change.
Change subject: core: manage-domains support the ldap provider type
......................................................................
Patch Set 2: Looks good to me, approved
(1 inline comment)
Just see my minor comment.
Besides that - all the rest is fine.
Once you refactor this, you can push.
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/ldap/LdapProviderType.java
Line 8: public static LdapProviderType valueOfIgnoreCase(String name) {
Please refactor this to generic method and move it to EnumUtils.
--
To view, visit http://gerrit.ovirt.org/3808
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd4a792be7a70637e2c84ed8d86b6c658becada9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
