Kanagaraj M has posted comments on this change.

Change subject: gluster: add glusterfs version into host detail view
......................................................................


Patch Set 5: Code-Review+2

(1 comment)

minor comment

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
Line 242: 
Line 243:     public void setGlusterVersion(RpmVersion value) {
Line 244:         if (Version.OpInequality(glusterVersion, value)) {
Line 245:             glusterVersion = value;
Line 246:             onPropertyChanged(new 
PropertyChangedEventArgs("glusterVersion")); //$NON-NLS-1$
change this to "GlusterVersion" to be consistent with rest of them
Line 247:         }
Line 248:     }
Line 249: 
Line 250:     private String iScsiInitiatorName;


-- 
To view, visit http://gerrit.ovirt.org/19862
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iabe7feeb4de647ba525bcdccf3f3513a2702796e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to