Vojtech Szocs has uploaded a new change for review. Change subject: webadmin: Fix findbugs 'ignore java.lang.Exception' warning ......................................................................
webadmin: Fix findbugs 'ignore java.lang.Exception' warning DynamicTabContainerPresenter.setInSlot method override repeats some code from superclass method (TabContainerPresenter.setInSlot) simply because it doesn't allow easy extension of its logic. This patch fixes 'ignore java.lang.Exception' findbugs warning by logging the exception via client-side logger infrastructure. Change-Id: I414216bdbf0419862a6beeebf037ec559d608290 Signed-off-by: Vojtech Szocs <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/DynamicTabContainerPresenter.java 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/56/21056/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/DynamicTabContainerPresenter.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/DynamicTabContainerPresenter.java index b04a486..752fd8e 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/DynamicTabContainerPresenter.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/DynamicTabContainerPresenter.java @@ -1,5 +1,8 @@ package org.ovirt.engine.ui.common.presenter; +import java.util.logging.Level; +import java.util.logging.Logger; + import com.google.gwt.core.client.Scheduler; import com.google.gwt.core.client.Scheduler.ScheduledCommand; import com.google.gwt.event.shared.EventBus; @@ -43,6 +46,8 @@ } + private static final Logger logger = Logger.getLogger(DynamicTabContainerPresenter.class.getName()); + private final Object tabContentSlot; private final Type<RequestTabsHandler> requestTabsEventType; @@ -69,7 +74,7 @@ TabContentProxy<?> proxy = (TabContentProxy<?>) presenter.getProxy(); getView().setActiveTabHistoryToken(proxy.getTargetHistoryToken()); } catch (Exception e) { - // Do nothing + logger.log(Level.SEVERE, "Error while updating tab view", e); //$NON-NLS-1$ } } } -- To view, visit http://gerrit.ovirt.org/21056 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I414216bdbf0419862a6beeebf037ec559d608290 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
