Einav Cohen has posted comments on this change. Change subject: userportal, webadmin: refactor: add model attribute for help tags ......................................................................
Patch Set 3: the helpTag is to understand the context of a dialog. A dialog won't necessarily have a main-tab/sub-tab location (e.g. 'Configure' dialog), dialog might have several possible locations from which it would be available (e.g. almost every dialog that is available from the 'Guide Me' dialog, 'VM Migrate' that is available from the VMs main tab as well as the Hosts main tab -> VMs sub-tab, "tomorrow" will will make actions available also from the left-pane tree, etc.) - therefore I prefer to not force any pattern. A free-text comment allows the developer to describe the dialog context as he sees fit, without limiting him in any way. If it was a simple change and/or it had real value for now, I would insist that a structured tag would be used here, but it is neither. Let's keep it simple, and continue with the free-text comment, please. Thanks. -- To view, visit http://gerrit.ovirt.org/21052 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4074fcc2ecfcbdd2ea6c0855d92f2aa4bd26a5b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
