Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: Update task status everytime while querying
......................................................................
Patch Set 3:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRemoveBricksStatusQuery.java
Line 81:
Line 82: // If the task status at engine side is aborted, set the
same to current status
Line 83: // This is required because even in case of retention of
the brick the gluster returns
Line 84: // the status as finished and to avoid enabling of retain
and commit in ui the status should
Line 85: // be set to aborted. This is required only in case of
remove bricks
As part of GlusterTaskUtils.updateSteps() there is check to see the value of
endTime for the step. If the same is not null (means step was marked
aborted/finished/failed etc earlier), the updation of the status is not to be
DB as its not required.
This makes sure the finished status from gluster would not be updated to DB and
below code would make sure UI renders the retain/commit buttons
enabled/disabled correctly.
Verified the same!
Line 86: if (jobStatusWithEngine == JobExecutionStatus.ABORTED) {
Line 87:
entity.getStatusSummary().setStatus(JobExecutionStatus.ABORTED);
Line 88: }
Line 89: }
--
To view, visit http://gerrit.ovirt.org/21005
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e8fa7ab590e15ee5821ae2f3fb41650c195c0fa
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
